Attention is currently required from: Felix Singer, Wonkyu Kim, Michał Żygowski, Benjamin Doron, Ravishankar Sarawadi, Stefan Reinauer, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs ......................................................................
Patch Set 7:
(11 comments)
Patchset:
PS7: last batch from me 😊
File util/inteltool/gpio_names/tigerlake.h:
https://review.coreboot.org/c/coreboot/+/56171/comment/9665c776_a042e5fe PS7, Line 30: n/a BKLTEN_SEC
https://review.coreboot.org/c/coreboot/+/56171/comment/c388cead_4528ba8f PS7, Line 31: n/a BKLTCTL_SEC
https://review.coreboot.org/c/coreboot/+/56171/comment/fb910d86_16a61d73 PS7, Line 179: _ I buy a `_group_` for consistency ;)
https://review.coreboot.org/c/coreboot/+/56171/comment/88a10eda_7097a7f8 PS7, Line 183: " missing comma
https://review.coreboot.org/c/coreboot/+/56171/comment/611b83f2_7299c400 PS7, Line 188: _ `_group_`
https://review.coreboot.org/c/coreboot/+/56171/comment/7827e4d2_2f51531c PS7, Line 411: B nit: 'B' means the same as '#', so maybe use '#' everywhere?
https://review.coreboot.org/c/coreboot/+/56171/comment/b46e31db_0ab66309 PS7, Line 544: vpgio3 p<->g
https://review.coreboot.org/c/coreboot/+/56171/comment/900f805c_6f17ca41 PS7, Line 576: "SPI0_TPM_CSB", "SPI0_TPM_CSB", : "SPI0_FLASH_0_CSB", "SPI0_FLASH_0_CSB", : "SPI0_FLASH_1_CSB", "SPI0_FLASH_1_CSB", : nit: I know, this comes from refcode, but at least for me the names are totally confusing.... what about SPI0_TPM_CS2#, SPI0_FLASH_CS0#, SPI0_FLASH_CS1#?
https://review.coreboot.org/c/coreboot/+/56171/comment/00ff080a_9693f3a5 PS7, Line 630: _vpgio3 p<->g
https://review.coreboot.org/c/coreboot/+/56171/comment/e1b956c8_f94ea872 PS7, Line 679: /* : * These pads start at offset 0x680, but according to EDS the PADBAR is 0x700. : * This would cause the tool to parse the GPIOs incorrectly. : * For informational purposes only. : */ : well, this would just be another group at index 0 of tigerlake_pch_h_community_0_groups and tigerlake_pch_h_community_0 would need another field `.padbar`