Attention is currently required from: John Su, YH Lin, Dtrain Hsu, Ian Feng, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, Eric Lai, Amanda Hwang, Ricky Chang.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62804 )
Change subject: mb/google/brya/var/banshee: Add mic mute switch setting
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/brya/variants/banshee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62804/comment/aaf5c753_796cdc1c
PS5, Line 328: register "privacy_gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_F19)"
Changing the privacy GPIO polarity is unrelated to the mic mute switch, it should go in a separate C […]
Removed it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f7176afbd64f7c080f02369f195043a2df88e5d
Gerrit-Change-Number: 62804
Gerrit-PatchSet: 8
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ricky Chang
rickytlchang@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Attention: Ricky Chang
rickytlchang@google.com
Gerrit-Comment-Date: Wed, 23 Mar 2022 08:23:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu
frank_wu@compal.corp-partner.google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment