Attention is currently required from: Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )
Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS1:
Done. I also removed is_big_endian in common.c, which was otherwise unused outside of swab.h.
Please make sure you keep the difference between ntohl and htonl (use be32toh and htobe32, respectively). While they compile to the same code it's important to distinguish them to communicate the intention behind it.
Patchset:
PS4:
Should I address the checkpatch lints (in existing code) in this change?
No, better leave it in a CL like this. (If you want to you can fix them in a separate patch.)