Hello Raul Rangel, Felix Held,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42532
to review the following change.
Change subject: cbmem: Remove IDs for TSEG and BERT ......................................................................
cbmem: Remove IDs for TSEG and BERT
Remove the changes added in 80df052d3 cbmem: Add IDs for TSEG and BERT table data
No platform uses either ID. TSEG in cbmem is incompatible with stage cache. BERT reserved data in cbmem is unusable in Linux.
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I5501424bfeb38d5ff5432678df9e08b4c16258f6 --- M src/commonlib/include/commonlib/cbmem_id.h 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/42532/1
diff --git a/src/commonlib/include/commonlib/cbmem_id.h b/src/commonlib/include/commonlib/cbmem_id.h index 65973c3..ac271a0 100644 --- a/src/commonlib/include/commonlib/cbmem_id.h +++ b/src/commonlib/include/commonlib/cbmem_id.h @@ -46,8 +46,6 @@ #define CBMEM_ID_ROMSTAGE_RAM_STACK 0x90357ac4 #define CBMEM_ID_ROOT 0xff4007ff #define CBMEM_ID_SMBIOS 0x534d4254 -#define CBMEM_ID_BERT_RAW_DATA 0x42455254 -#define CBMEM_ID_SMM_TSEG_SPACE 0x54534547 #define CBMEM_ID_SMM_SAVE_SPACE 0x07e9acee #define CBMEM_ID_STAGEx_META 0x57a9e000 #define CBMEM_ID_STAGEx_CACHE 0x57a9e100 @@ -113,8 +111,6 @@ { CBMEM_ID_ROMSTAGE_RAM_STACK, "ROMSTG STCK" }, \ { CBMEM_ID_ROOT, "CBMEM ROOT " }, \ { CBMEM_ID_SMBIOS, "SMBIOS " }, \ - { CBMEM_ID_BERT_RAW_DATA, "BERT DATA " }, \ - { CBMEM_ID_SMM_TSEG_SPACE, "TSEG " }, \ { CBMEM_ID_SMM_SAVE_SPACE, "SMM BACKUP " }, \ { CBMEM_ID_STORAGE_DATA, "SD/MMC/eMMC" }, \ { CBMEM_ID_TCPA_LOG, "TCPA LOG " }, \