Attention is currently required from: Hung-Te Lin, Marc Jones, Furquan Shaikh, Ricardo Quesada, Julius Werner. Hello Hung-Te Lin, Marc Jones, build bot (Jenkins), Furquan Shaikh, Marc Jones, Jack Rosenthal, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56904
to look at the new patch set (#2).
Change subject: include/bcd: move bcd code to commonlib/bsd/include ......................................................................
include/bcd: move bcd code to commonlib/bsd/include
Move bcd2bin() / bin2bcd() functions to commonlib/bsd/include/
Also, the license is changed from GPL to BSD. This is because it is needed from "utils" (see CL in the chain).
For reference bin2bcd() & bcd2bin() are very simple functions. And there are already BSD implementations of them, like these ones, to name a few: https://chromium.googlesource.com/chromiumos/platform/mosys/+/refs/heads/mai... http://web.mit.edu/freebsd/head/sys/contrib/octeon-sdk/cvmx-cn3010-evb-hs5.c
BUG=b:172210863 TEST=make (everything compiled Ok).
Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72 Signed-off-by: Ricardo Quesada ricardoq@google.com --- R src/commonlib/bsd/include/commonlib/bsd/bcd.h M src/drivers/ams/as3722rtc.c M src/drivers/elog/elog.c M src/drivers/i2c/pcf8523/pcf8523.c M src/drivers/i2c/rx6110sa/rx6110sa.c M src/drivers/pc80/rtc/mc146818rtc.c M src/drivers/ti/tps65913/tps65913rtc.c M src/include/cper.h M src/soc/mediatek/common/include/soc/rtc_common.h M src/soc/rockchip/common/rk808.c 10 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/56904/2