Attention is currently required from: Malik Hsu, Nick Vaccaro, Casper Chang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60071 )
Change subject: mb/google/brya/var/primus: Configure Acoustic noise mitigation
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60071/comment/bd4ad165_f0d37c0f
PS1, Line 7: primus
Sometimes we use shell-like glob sequences to indicate we are modifying more than one board, in this case:
`mb/google/brya/var/primus{4es}`
shows you are modifying both
https://review.coreboot.org/c/coreboot/+/60071/comment/76e141e6_daff82d6
PS1, Line 8:
Maybe mention that this was verified to meet the audible noise specification (or is still in testing) ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60071
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e0baf78a841278efda912cc5e4e9970329aacf6
Gerrit-Change-Number: 60071
Gerrit-PatchSet: 1
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Comment-Date: Mon, 13 Dec 2021 19:49:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment