Attention is currently required from: Raul Rangel, Paul Menzel, Karthik Ramasubramanian, Felix Held.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60214 )
Change subject: soc/amd/cezanne: Correct S0i3 verstage softfuse bit
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60214/comment/b6c4e6fd_b388a7f4
PS1, Line 9: PSP_S0I3_RESUME_VERSTAGE softfuse bit is 58, not 40.
Where is that documented?
In b/202397678, it is not documented publicly.
https://review.coreboot.org/c/coreboot/+/60214/comment/cadce0e2_bd308b5b
PS1, Line 14: latest PSP.
Should fit in one line.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia27f6e48e345aac0d5f6579d663a6b655688239a
Gerrit-Change-Number: 60214
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 20 Dec 2021 15:27:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment