Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42691 )
Change subject: soc/amd/common: Refactor single GPIO programming ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42691/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42691/4/src/soc/amd/common/block/gp... PS4, Line 216: if (gev_tbl == NULL) I'm sorry I'm currently being lazy. Could we lift the logic exactly in one patch and then modify accordingly to see the diff? I understand if you don't want to. I'll just need to come back w/ more scrutiny later. general approach looks good to me: let the compiler optimize whatever it wants and make things more readable.