Hello Sumeet Pawnikar,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42513
to review the following change.
Change subject: tigerlake: enable tcc_offset functionality ......................................................................
tigerlake: enable tcc_offset functionality
This enables Thermal Control Circuit (TCC) activation feature to set tcc_offset value to new value as 10 degree Celcius in devicetree.
BUG=None BRANCH=None TEST=Built for volteer platform and verified the MSR value.
Change-Id: I36b0d6aad4be8a9cbb145dcd66d65235d3f6ac35 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.corp-partner.google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/soc/intel/tigerlake/cpu.c M src/soc/intel/tigerlake/fsp_params.c 3 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/42513/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 8cd926c..18b436d 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -205,6 +205,8 @@
register "Device4Enable" = "1"
+ register "tcc_offset" = "10" # TCC of 90C + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | diff --git a/src/soc/intel/tigerlake/cpu.c b/src/soc/intel/tigerlake/cpu.c index ec78d15..b95fdc6 100644 --- a/src/soc/intel/tigerlake/cpu.c +++ b/src/soc/intel/tigerlake/cpu.c @@ -216,4 +216,7 @@ { if (mp_init_with_smm(cpu_bus, &mp_ops)) printk(BIOS_ERR, "MP initialization failure.\n"); + + /* Thermal throttle activation offset */ + configure_thermal_target(); } diff --git a/src/soc/intel/tigerlake/fsp_params.c b/src/soc/intel/tigerlake/fsp_params.c index 3fbb89a..a612427 100644 --- a/src/soc/intel/tigerlake/fsp_params.c +++ b/src/soc/intel/tigerlake/fsp_params.c @@ -213,6 +213,9 @@ /* Enable TCPU for processor thermal control */ params->Device4Enable = config->Device4Enable;
+ /* Set TccActivationOffset */ + params->TccActivationOffset = config->tcc_offset; + /* LAN */ dev = pcidev_path_on_root(PCH_DEVFN_GBE); if (!dev)