Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Zheng Bao, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69429 )
Change subject: amdfwtool: Set the base address of AMDFW as relative ......................................................................
Patch Set 1:
(7 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163165): https://review.coreboot.org/c/coreboot/+/69429/comment/6b082694_23a8697b PS1, Line 2294: case 0: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163165): https://review.coreboot.org/c/coreboot/+/69429/comment/cf64f1c6_35011506 PS1, Line 2295: case 0xFA0000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163165): https://review.coreboot.org/c/coreboot/+/69429/comment/f0cd850e_d798126b PS1, Line 2296: case 0xF20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163165): https://review.coreboot.org/c/coreboot/+/69429/comment/fb9b707c_5e25c85c PS1, Line 2297: case 0xE20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163165): https://review.coreboot.org/c/coreboot/+/69429/comment/a5b33e24_ce56ec2f PS1, Line 2298: case 0xC20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163165): https://review.coreboot.org/c/coreboot/+/69429/comment/af59bda7_81697af5 PS1, Line 2299: case 0x820000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163165): https://review.coreboot.org/c/coreboot/+/69429/comment/f0b066dc_02b8e49d PS1, Line 2300: case 0x020000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment