Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62980 )
Change subject: mb/google/guybrush/var/nipperkin: update telemetry settings ......................................................................
mb/google/guybrush/var/nipperkin: update telemetry settings
Update the two load line slope settings for the telemetry. AGESA sends these values to the SMU, which accepts them as units of current. Proper calibration is determined by the AMD SDLE tool and the Stardust test.
VDD scale: 73331 -> 94623 VDD offset: 1893 -> 1847 SOC scale: 31955 -> 29904 SOC offset: 852 -> 756
BUG=b:217963719 BRANCH=guybrush TEST=emerge-guybrush coreboot chromeos-bootimage pass AMD SDLE/Stardust test
Change-Id: Icad97644dd9391a325dfe1dbb1ec176e1f6d3dc3 Signed-off-by: Kevin Chiu kevin.chiu.17802@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/62980 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Raul Rangel: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb index 668c109..6d6285a 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb @@ -207,10 +207,10 @@ register "sustained_power_limit_mW" = "12000" register "thermctl_limit_degreeC" = "100"
- register "telemetry_vddcrvddfull_scale_current_mA" = "73331" #mA - register "telemetry_vddcrvddoffset" = "1893" - register "telemetry_vddcrsocfull_scale_current_mA" = "31955" #mA - register "telemetry_vddcrsocoffset" = "852" + register "telemetry_vddcrvddfull_scale_current_mA" = "94623" #mA + register "telemetry_vddcrvddoffset" = "1847" + register "telemetry_vddcrsocfull_scale_current_mA" = "29904" #mA + register "telemetry_vddcrsocoffset" = "756"
# Enable STT support register "stt_control" = "1"