[coreboot-gerrit] [XS] Change in coreboot[master]: acpi.c: Find FACS using 64bit address fields

[Arthur Heymans (Code Review)]

Attention is currently required from: Lance Zhao.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76293?usp=email )

Change subject: acpi.c: Find FACS using 64bit address fields
......................................................................

Patch Set 2:

(1 comment)

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/76293/comment/ad0d1637_79074969 :
PS2, Line 1633: 			       | (uint64_t)fadt->x_firmware_ctl_h << 32);
> For some reason, src/southbridge/amd/pi/hudson/fadt.c has this:
>
> fadt->x_firmware_ctl_l = 0;	/* set to 0 if firmware_ctrl is used */
>    fadt->x_firmware_ctl_h = 0;
>
> The only hardware using this now, pcengines/apu[2..6] do not support S3 but I think this change would break S3 resume if FACS was ever located above 4G.

I guess that can safely be removed.