Attention is currently required from: Bob Moragues, Philip Chen, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57720 )
Change subject: herobrine: Add Hoglin variant
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/57720/comment/18195eab_c6bf5cdc
PS1, Line 8: BOARD_GOOGLE_PIGLIN && BOARD_GOOGLE_HOGLIN
Ha, yes (facepalm).
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57720
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I883d17b3ad3c7e44a00f0d0e7007c119417c5028
Gerrit-Change-Number: 57720
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bob Moragues
moragues@google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Philip Chen
philipchen@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Bob Moragues
moragues@chromium.org
Gerrit-Comment-Date: Thu, 16 Sep 2021 19:09:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Bob Moragues
moragues@google.com
Gerrit-MessageType: comment