Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: menovo/{t60,r60}: Add ThinkPad R60 support as variant board
......................................................................
Patch Set 26:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35864/26/Documentation/mainboard/le...
File Documentation/mainboard/lenovo/r60.md:
https://review.coreboot.org/c/coreboot/+/35864/26/Documentation/mainboard/le...
PS26, Line 22: installation
configuration
https://review.coreboot.org/c/coreboot/+/35864/20/src/mainboard/lenovo/t60/v...
File src/mainboard/lenovo/t60/variants/r60/gpio.c:
https://review.coreboot.org/c/coreboot/+/35864/20/src/mainboard/lenovo/t60/v...
PS20, Line 30: .gpio21 = GPIO_MODE_GPIO, /* LCD_PRESENCE */
This good? […]
just #if. Also do it for input
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd9208a5eafd228f8eedbc8fb4f4eb9ed1932a14
Gerrit-Change-Number: 35864
Gerrit-PatchSet: 26
Gerrit-Owner: Maccraft123
maccraft123mc@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Maccraft123
maccraft123mc@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Oct 2019 10:42:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maccraft123
maccraft123mc@gmail.com
Gerrit-MessageType: comment