Attention is currently required from: Mac Chiang, Pranava Y N.
Weimin Wu has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85571?usp=email )
Change subject: drivers/soundwire: Support Realtek ALC712 codec ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/85571/comment/b56d3c80_2420f8f0?usp... : PS2, Line 13: static struct soundwire_multilane alc711_multilane = { : };
do you wish to keep the default value for case when chip config hasn't been provided `config->multil […]
Because I don't know how the default value should be configured, and if the chip config does not provide data, then because lane_mapping_count and lane_bus_holder_count are 0, no extra data will be generated, except that one more soundwire_gen_interface_revision(dsd) will be generated. To be honest, I am not sure whether it will cause interference, these need to be confirmed by actual debugging on the board.