Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45710 )
Change subject: x86: Add a fake SoC along with a board for build testing
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45710/1/src/soc/fake/x86/chip.c
File src/soc/fake/x86/chip.c:
https://review.coreboot.org/c/coreboot/+/45710/1/src/soc/fake/x86/chip.c@1
PS1, Line 1: #include <device/device.h>
SPDX-License ?
For what exactly? I wrote this from scratch and it contains not a single
line of code. If I did something wrong, some lint script should have caught
me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id76ab15fe77ae3e405c43f9c8677694f178be112
Gerrit-Change-Number: 45710
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 25 Sep 2020 19:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment