[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Set default USB3 de-emphasis to -3.5dB

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43831 )

Change subject: soc/intel/tigerlake: Set default USB3 de-emphasis to -3.5dB
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43831/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43831/1//COMMIT_MSG@10 
PS1, Line 10: log
Hmm, using 0x29 = 41 results in -3.86 dB, which isn't very accurate (0x2a or 0x2b would be closer to -3.5 dB)

Also, Only SKL seems to use that de-emphasis value. Other platforms just set it to zero, which is treated as a no-op when copying the parameters to the FSP UPDs. However, the UPDs seem to default to 0x29. Maybe the TGL FSP has some problem?