Attention is currently required from: Felix Singer, Maxim, Michał Żygowski, Nicholas Chin, Paul Menzel.
Alicja Michalska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80853?usp=email )
Change subject: mb/erying: Add Erying Polestar G613 Pro (TGL-H) ......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/erying/tgl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80853/comment/8ce77aa3_63d9c4f5 : PS7, Line 125: device ref pch_espi on
What about `gen1_dec` to access I/O Range for ITE SuperIO HWM/EC? […]
I wasn't sure how to configure it to be perfectly honest.
Looked at other boards which use ITE IT8728F SIO (which I have a datasheet for), and nobody used that option.
While booting the system with current configuration, I have an error that it ran out of IO windows. ``` [DEBUG] PNP: 002e.1 60 <- [0x00000000000003f8 - 0x00000000000003ff] size 0x00000008 gran 0x03 io [DEBUG] PNP: 002e.1 70 <- [0x0000000000000004 - 0x0000000000000004] size 0x00000001 gran 0x00 irq [DEBUG] PNP: 002e.1 f0 <- [0x0000000000000001 - 0x0000000000000001] size 0x00000001 gran 0x00 irq [DEBUG] PNP: 002e.4 60 <- [0x0000000000000a30 - 0x0000000000000a37] size 0x00000008 gran 0x03 io [DEBUG] PNP: 002e.4 62 <- [0x0000000000000a20 - 0x0000000000000a27] size 0x00000008 gran 0x03 io [DEBUG] PNP: 002e.4 70 <- [0x0000000000000000 - 0x0000000000000000] size 0x00000001 gran 0x00 irq [DEBUG] PNP: 002e.4 f4 <- [0x00000000000000e0 - 0x00000000000000df] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.4 f5 <- [0x0000000000000000 - 0xffffffffffffffff] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.4 f6 <- [0x00000000000000f0 - 0x00000000000000ef] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 29 <- [0x00000000000000c0 - 0x00000000000000bf] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 2c <- [0x0000000000000041 - 0x0000000000000040] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 2d <- [0x0000000000000002 - 0x0000000000000001] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 60 <- [0x0000000000000a10 - 0x0000000000000a13] size 0x00000004 gran 0x02 io [DEBUG] PNP: 002e.7 62 <- [0x0000000000000a00 - 0x0000000000000a07] size 0x00000008 gran 0x03 io [DEBUG] PNP: 002e.7 70 <- [0x0000000000000000 - 0x0000000000000000] size 0x00000001 gran 0x00 irq [DEBUG] PNP: 002e.7 71 <- [0x0000000000000001 - 0x0000000000000000] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 bc <- [0x00000000000000c0 - 0x00000000000000bf] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 bd <- [0x0000000000000003 - 0x0000000000000002] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 c1 <- [0x0000000000000002 - 0x0000000000000001] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 c8 <- [0x0000000000000000 - 0xffffffffffffffff] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 c9 <- [0x0000000000000002 - 0x0000000000000001] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 da <- [0x00000000000000b0 - 0x00000000000000af] size 0x00000000 gran 0x00 irq [DEBUG] PNP: 002e.7 db <- [0x0000000000000044 - 0x0000000000000043] size 0x00000000 gran 0x00 irq [DEBUG] LPC: enabling default decode range LPC_IOE_COMA_EN [DEBUG] LPC: Opened IO window LGIR1: base a30 size 8 [DEBUG] LPC: Opened IO window LGIR2: base a20 size 8 [DEBUG] LPC: Opened IO window LGIR3: base a10 size 4 [ERROR] LPC: Cannot open IO window: a00 size 8 [ERROR] No more IO windows ``` (Full cbmem here: https://f.sakamoto.pl/elly/coreboot/cbmem-erying.txt)