Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74392 )
Change subject: screebo: initial coreboot for rex variant ......................................................................
Patch Set 1:
(12 comments)
File src/mainboard/google/rex/variants/screebo/fw_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/13db1bd5_36578aa4 PS1, Line 47: // printk(BIOS_INFO, "Configure GPIOs for no audio.\n"); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/5b959a51_99a1cbdd PS1, Line 48: // GPIO_PADBASED_OVERRIDE(padbased_table, i2s_disable_pads); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/9e83d32b_50c65b60 PS1, Line 49: // GPIO_PADBASED_OVERRIDE(padbased_table, dmic_disable_pads); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/86a33732_d5d114f8 PS1, Line 50: // GPIO_PADBASED_OVERRIDE(padbased_table, sndw_disable_pads); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/0fea3b76_bc08c291 PS1, Line 52: // printk(BIOS_INFO, "Configure GPIOs for SoundWire audio.\n"); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/e8b5f478_28c5fe99 PS1, Line 53: // GPIO_PADBASED_OVERRIDE(padbased_table, i2s_disable_pads); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/5d2d4d07_34366c0d PS1, Line 55: // printk(BIOS_INFO, "Configure GPIOs for I2S audio.\n"); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/f2085051_86dff063 PS1, Line 56: // GPIO_PADBASED_OVERRIDE(padbased_table, sndw_disable_pads); please, no space before tabs
File src/mainboard/google/rex/variants/screebo/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/f2b821a3_eaa420f1 PS1, Line 17: // if (fw_config_probe(FW_CONFIG(UFC, UFC_USB))) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/ced40dc3_4375abe8 PS1, Line 18: // acpigen_soc_clear_tx_gpio(GPP_B09); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/db1e5617_030b0bb1 PS1, Line 20: // if (fw_config_probe(FW_CONFIG(UFC, UFC_USB))) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174086): https://review.coreboot.org/c/coreboot/+/74392/comment/f25baf62_aa73135c PS1, Line 21: // acpigen_soc_set_tx_gpio(GPP_B09); please, no space before tabs