[coreboot-gerrit] [XS] Change in coreboot[main]: vc/amd/opensil/genoa_poc/opensil_console: fix host debug print function

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80203?usp=email )

Change subject: vc/amd/opensil/genoa_poc/opensil_console: fix host debug print function
......................................................................

vc/amd/opensil/genoa_poc/opensil_console: fix host debug print function

Since we pass va_list list to the print function, we need to use vprintk
instead of printk. Earlier versions of this code used vsnprintf and a
local buffer, but when that code was reworked to not need the temporary
buffer, it was replaced by printk instead of the correct vprintk.

TEST=Now the console output from openSIL looks as expected:

Example line from openSIL's console output when it prints the MPIO
configuration from a log some commits before this patch:

Host PCI Address - -1352681400:-1353251983:7

Same line with this patch applied looks how it's supposed to:

Host PCI Address - 0:0:0

Signed-off-by: Felix Held 
Tested-by: Varshit Pandya 
Change-Id: Ia931cc80dea5b7eabb75cfb19f8baa9a09cd2dbf
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80203
Reviewed-by: Matt DeVillier 
Reviewed-by: Arthur Heymans 
Reviewed-by: Varshit Pandya 
Tested-by: build bot (Jenkins) 
---
M src/vendorcode/amd/opensil/genoa_poc/opensil_console.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved
  Arthur Heymans: Looks good to me, approved
  Varshit Pandya: Looks good to me, approved

diff --git a/src/vendorcode/amd/opensil/genoa_poc/opensil_console.c b/src/vendorcode/amd/opensil/genoa_poc/opensil_console.c
index 55a3521..35e5eeb 100644
--- a/src/vendorcode/amd/opensil/genoa_poc/opensil_console.c
+++ b/src/vendorcode/amd/opensil/genoa_poc/opensil_console.c
@@ -39,6 +39,6 @@
    /* print formatted message */
    va_list args;
    va_start(args, Line);
-	printk(loglevel, Message, args);
+	vprintk(loglevel, Message, args);
    va_end(args);
 }