Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )
Change subject: xeon_sp: Fix skx uncore.asl _SB namespace issue
......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
I think it is ASL 2.0 syntax.
I think the syntax has always been _ and this was a typo/general bug.
https://review.coreboot.org/c/coreboot/+/45269/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45269/1//COMMIT_MSG@7
PS1, Line 7: xeon_sp: Fix skx uncore.asl _SB namespace issue
For the title, we have been using this format for the code area: soc/intel/xeon_sp/skx
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45269
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I799042babbe60287e5e4ec60b21c08d57ccda04b
Gerrit-Change-Number: 45269
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Sep 2020 19:51:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment