Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47301 )
Change subject: soc/intel/xeon_sp: Improve generating PCH IOAPIC MADT entry ......................................................................
Patch Set 6:
(2 comments)
A couple of nits. It is almost ready to +2.
https://review.coreboot.org/c/coreboot/+/47301/6/src/soc/intel/xeon_sp/acpi.... File src/soc/intel/xeon_sp/acpi.c:
https://review.coreboot.org/c/coreboot/+/47301/6/src/soc/intel/xeon_sp/acpi.... PS6, Line 108: int ioapic_id = ioapic_ids[cur_index]; : int gsi_base = gsi_bases[cur_index]; Is there a reason to not declare these above so we don't don't do it twice and need a new scope here? A comment that this is setting the PCH IOAPIC and then the IIO APICs would be good. I know it is easier to see that in the next patch.
https://review.coreboot.org/c/coreboot/+/47301/6/src/soc/intel/xeon_sp/acpi.... PS6, Line 130: * Add entry for PCH IOAPIC. Does this comment need an update? I think that this is the IIO APIC entry.