Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47531 )
Change subject: soc/intel/common/block/p2sb: Add hpet BDF functions
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47531/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/p2sb/p2sb.c:
https://review.coreboot.org/c/coreboot/+/47531/6/src/soc/intel/common/block/...
PS6, Line 33: pci_write_config32(PCH_DEV_P2SB, PCI_BASE_ADDRESS_0, P2SB_BAR);
nit: put `raw` after the struct? […]
Yes. No idea how this comment ended up here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47531
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d72da8bc392aa144d167d31cde30cc71cd1396e
Gerrit-Change-Number: 47531
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Nov 2020 10:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment