Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42392 )
Change subject: src: Remove unused include <cpu/x86/smm.h> ......................................................................
src: Remove unused include <cpu/x86/smm.h>
Found using: diff <(git grep -l '#include <cpu/x86/smm.h>' -- src/) <(git grep -l 'SMM_DEFAULT_BASE|SMM_DEFAULT_SIZE|SMM_BASE|SMM_ENTRY_OFFSET|SMM_SAVE_STATE_BEGIN|APM_CNT|APM_STS|apm_control|set_smm_gnvs_ptr|set_acpi_mode_on_exit|io_trap_handler|southbridge_io_trap_handler|mainboard_io_trap_handler|southbridge_smi_set_eos|smm_southbridge_clear_state|global_smi_enable|global_smi_enable_no_pwrbtn|cpu_smi_handler|northbridge_smi_handler|southbridge_smi_handler|mainboard_smi_gpi|mainboard_smi_apmc|mainboard_smi_sleep|smramc_dev|smramc_reg|run_smm_relocate|smm_is_really_enabled|is_smm_enabled|smram_open|smram_close|smram_lock|smm_open|smm_close|smm_lock|_binary_smm_start|_binary_smm_end|smm_runtime|smm_module_params|smm_handler_start|smm_get_save_state|smm_handler_t|smm_loader_params|smm_setup_relocation_handler|smm_load_module|backup_default_smm_area|restore_default_smm_area|smm_region|SMM_SUBREGION_HANDLER|SMM_SUBREGION_CACHE|SMM_SUBREGION_CHIPSET|SMM_SUBREGION_NUM|smm_subregion|smm_list_regions' -- src/)|grep '<'
Change-Id: Id96ddad974a1460a6e6580cee1e45c863761af06 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/42392 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/smmstore/smi.c M src/soc/intel/skylake/romstage/romstage.c 2 files changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/drivers/smmstore/smi.c b/src/drivers/smmstore/smi.c index b21423e..877ed20 100644 --- a/src/drivers/smmstore/smi.c +++ b/src/drivers/smmstore/smi.c @@ -2,7 +2,6 @@
#include <console/console.h> #include <commonlib/region.h> -#include <cpu/x86/smm.h> #include <smmstore.h> #include <stddef.h> #include <stdint.h> diff --git a/src/soc/intel/skylake/romstage/romstage.c b/src/soc/intel/skylake/romstage/romstage.c index 99f444a..9ae854d 100644 --- a/src/soc/intel/skylake/romstage/romstage.c +++ b/src/soc/intel/skylake/romstage/romstage.c @@ -4,7 +4,6 @@ #include <arch/symbols.h> #include <assert.h> #include <cpu/x86/msr.h> -#include <cpu/x86/smm.h> #include <cbmem.h> #include <console/console.h> #include <device/pci_def.h>