[coreboot-gerrit] [M] Change in coreboot[master]: mb/google/rex/variants/ovis: Add USB and TCSS configuration

[Kapil Porwal (Code Review)]

Attention is currently required from: Jakub Czapiga, Subrata Banik, Tarun Tuli.

Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75578?usp=email )

Change subject: mb/google/rex/variants/ovis: Add USB and TCSS configuration
......................................................................

Patch Set 5:

(1 comment)

File src/mainboard/google/rex/variants/ovis/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/75578/comment/d3aa56dd_bbdcce5b :
PS1, Line 89: 		device ref tcss_dma0 on
            : 			chip drivers/intel/usb4/retimer
            : 				register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)"
            : 				use tcss_usb3_port1 as dfp[0].typec_port
            : 				device generic 0 on end
            : 			end
            : 		end
            : 		device ref tcss_dma1 on
            : 			chip drivers/intel/usb4/retimer
            : 				register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)"
            : 				use tcss_usb3_port2 as dfp[0].typec_port
            : 				device generic 0 on end
            : 			end
            : 		end
> Shouldn't the port2 have `generic 1` to match dfp index?

We can but it will not have any impact because the retimer chip driver is not using the device ID.

You can confirm this by comparing the output of below commands with `generic 0` and `generic 1`
```
cd /tmp
cp /sys/firmware/acpi/tables/SSDT .
iasl -d SSDT
sed -n '/Scope.*TDM/,/^    }/ p' SSDT.dsl
```