Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36341 )
Change subject: security/vboot: Build vboot library with same .a that depthcharge uses
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36341/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36341/1//COMMIT_MSG@9
PS1, Line 9: Switch from fwlib20 to fwlib
I'm confused by this. Isn't this effectively going back to vboot 1 APIs? depthcharge uses the old vboot API, and we want to change that -- not make coreboot use the old one again. The commit description needs some modification to be clearer w.r.t. to the intent and reasoning. Don't just state what is happening.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I905b781c3596965ec7ef45a2a7eafe15fdd4d9cc
Gerrit-Change-Number: 36341
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 25 Oct 2019 21:14:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment