Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31603 )
Change subject: mainboard: Add ASRock H110M-DVS
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31603/5/src/mainboard/asrock/h110m/include/h...
File src/mainboard/asrock/h110m/include/hda_verb.h:
https://review.coreboot.org/#/c/31603/5/src/mainboard/asrock/h110m/include/h...
PS5, Line 4: * Copyright (C) 2017 Intel Corporation
if you don't use variants, the file contents can be moved to hda_verb.c
https://review.coreboot.org/#/c/31603/5/src/mainboard/asrock/h110m/spd/spd_u...
File src/mainboard/asrock/h110m/spd/spd_util.c:
https://review.coreboot.org/#/c/31603/5/src/mainboard/asrock/h110m/spd/spd_u...
PS5, Line 4: * Copyright (C) 2016 Intel Corporation.
move everything to romstage.c and make it static
there's no need for additonal files
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31603
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69396edc50948cf1d0da649241ce92171d32daf7
Gerrit-Change-Number: 31603
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 28 Feb 2019 08:29:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
