Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth, Nicholas Chin.
Matt DeVillier has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/84046?usp=email )
Change subject: Docs/releases: Update 24.08 release notes ......................................................................
Patch Set 2:
(14 comments)
File Documentation/releases/coreboot-24.08-relnotes.md:
PS1:
Enclose all URLs in angle brackets so that they are rendered as links: […]
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/a1951cb6_3a81303a?usp... : PS1, Line 16: november
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/0b11f397_388b7e7e?usp... : PS1, Line 38: Ticket: https://ticket.coreboot.org/issues/522 : Review: https://review.coreboot.org/79905
Newlines without a blank line don't get rendered, so these appear on the same line. […]
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/6dbf5e46_6e8cd93e?usp... : PS1, Line 65: which were mostly fixed
Grammar: which (the issue) *was* mostly fixed […]
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/91675274_d8c78fa5?usp... : PS1, Line 82: [1] https://lore.kernel.org/qemu-devel/1504626814-23124-1-git-send-email-peter.m... : [2] https://review.coreboot.org/c/coreboot/+/34774 : [3] https://review.coreboot.org/c/coreboot/+/36486 : [4] https://qemu-project.gitlab.io/qemu/system/arm/virt.html : [5] https://qemu-project.gitlab.io/qemu/system/riscv/virt.html
These render as one paragraph (and without hyperlinks as noted above) […]
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/d0214c22_353ea4c8?usp... : PS1, Line 118: HUTRR94: https://www.usb.org/sites/default/files/hutrr94_-_system_do_not_disturb.pdf : HUTRR116: https://www.usb.org/sites/default/files/hutrr116-systemaccessbilitybinding_2...
These will render as one paragraph with no line break.
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/fa90ae64_6290a452?usp... : PS1, Line 121: Review: https://review.coreboot.org/c/coreboot/+/82997 : Review: https://review.coreboot.org/c/coreboot/+/82996
These will render as one paragraph with no line break
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/9d6d39d8_0a795648?usp... : PS1, Line 142: ../cbfstool/linux_trampoline.S: Assembler messages: : ../cbfstool/linux_trampoline.S:100: Error: no instruction mnemonic : suffix given and no register operands; can't size : instruction : <builtin>: recipe for target '../cbfstool/linux_trampoline.o' : failed
This renders as a single paragraph without the line breaks. […]
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/689fb7f6_835ad113?usp... : PS1, Line 183: LBBR Test: : // 1. dump FDT from QEMU like mentioned in aarch64 coreboot doc : // 2. compile u-root however you like (aarch64) : // 3. compile Linux (embed u-root initramfs via Kconfig) : // 4. copy Linux kernel to payloads/leanefi/Image : // 5. copy following coreboot defconfig to configs/defconfig: : CONFIG_BOARD_EMULATION_QEMU_AARCH64=y : CONFIG_PAYLOAD_NONE=n : CONFIG_PAYLOAD_LEANEFI=y : CONFIG_LEANEFI_PAYLOAD=y : CONFIG_LEANEFI_PAYLOAD_PATH="[path-to-linux]/arch/arm64/boot/Image" : CONFIG_LEANEFI_FDT=y : CONFIG_LEANEFI_FDT_PATH="[path-to-dumped-DTB]" : // 6. compile coreboot : make defconfig : make -j$(nproc) : // 7. run qemu like mentioned in coreboot doc (no FIT) : // 8. say hello to u-root and optionally kexec into the next kernel
This renders as a single paragraph with no line breaks since markdown ignores newline characters bet […]
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/68ea5136_068e070e?usp... : PS1, Line 210: haswell
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/f4032453_14b69eb4?usp... : PS1, Line 287: * src/soc/intel/pantherlake
I think a verb is missing? […]
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/a6a7d83a_e4355c9d?usp... : PS1, Line 312: ##
Increase these by one header level to H3 so that they fall under the "Significant Known and Open Iss […]
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/7fe7ca88_0d96beea?usp... : PS1, Line 325: ##
Same as above […]
Done
https://review.coreboot.org/c/coreboot/+/84046/comment/7c165aeb_bf8239cd?usp... : PS1, Line 346: ##
Same as above […]
Done