Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33143 )
Change subject: Rampayload: Able to build coreboot without ramstage
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33143/3/toolchain.inc
File toolchain.inc:
https://review.coreboot.org/#/c/33143/3/toolchain.inc@50
PS3, Line 50: ifeq ($(CONFIG_RAMPAYLOAD),y)
without this changes, i'm getting below error when my soc doesn't select ARCH_RAMSTAGE […]
That sounds like another good reason to just not touch the toolchain Kconfigs (like ARCH_RAMSTAGE_X86), and deal with this on another level. There's no harm having a toolchain assigned to the ramstage as long as you just don't build it. Doing it that way would require a lot less special casing for this feature.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id000dfac2eb57a8eaaa505c89d798fb30b3706fe
Gerrit-Change-Number: 33143
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Jun 2019 22:32:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment