Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43846 )
Change subject: soc/skylake: Enable DCI depending on devicetree configuration
......................................................................
Patch Set 1:
Some mainboards have turned on DCI in the devicetree, which AFAIK had no effect until now. Thus this patch would enable the DCI controller.
Please have a look at this. I just want to make sure this is really intended and doesn't result in a security issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43846
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic816655d87cee9e56520aa30fc3c837b561f24e5
Gerrit-Change-Number: 43846
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Sat, 25 Jul 2020 08:57:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment