Attention is currently required from: Paul Menzel, Angel Pons, Shuming Chu (Shuming), Tim Chu.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68902 )
Change subject: src/include/smbios: Add definition for smbios type 4 and type 9
......................................................................
Patch Set 5: Code-Review+2
(3 comments)
File src/include/smbios.h:
https://review.coreboot.org/c/coreboot/+/68902/comment/b78fc2ef_9ecdad1d
PS5, Line 488: /* defines for processor family */
https://web.archive.org/web/20221012222420/https://www.dmtf.org/sites/defaul...
Table 23 – Processor Information: Processor Family field
https://review.coreboot.org/c/coreboot/+/68902/comment/4beaf784_413dfba0
PS5, Line 493: /* defines for processor characteristics */
Table 27 – Processor Characteristics
https://review.coreboot.org/c/coreboot/+/68902/comment/eef7fa45_36ee6d37
PS5, Line 697: /* System Slots - Slot Type */
Table 45 – System Slots: Slot Type field
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I559995b0204f8e5bdeef2c0f8b394f9011d72240
Gerrit-Change-Number: 68902
Gerrit-PatchSet: 5
Gerrit-Owner: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 10 Nov 2022 19:05:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment