Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43294 )
Change subject: mb/google/dedede: Change HDMI DDC GPIOs to native function
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43294/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/43294/2/src/mainboard/google/dedede...
PS2, Line 225: PAD_CFG_NF(GPP_E16, NONE, DEEP, NF1),
As I know, we never use DDI0/1 as the native HDMI interface so will we need to configure them as the […]
Since this is generic configuration of dedede baseboard, we need to set it if we're planning to use it on other variants/boards. Ideally SoC supports on all ports, so I was setting it...I can remove configuration on port 0/1 if we're not planning to use it for any dedede variant.
@Karthik, Can you please confirm this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If02f062132d7c3b01b07ea9401e81f451df35c3c
Gerrit-Change-Number: 43294
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Kirtika Ruchandani
kirtika@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jul 2020 13:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment