Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47032 )
Change subject: sb/intel/lynxpoint/sata.c: Update as per newer reference code ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47032/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/sata.c:
https://review.coreboot.org/c/coreboot/+/47032/3/src/southbridge/intel/lynxp... PS3, Line 170: /* Additional Programming Requirements */ actually this looks like the heading for lines 171-201, while "Power Optimizer" and "Clock Gating" where subheadings. Thus, the change on the right doesn't make sense. When these are "additional programming requirements for p.o", where are the "programming requirements"? -> just drop line 170 should be ok