Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31618
Change subject: [WIP] console: Refactor printk() varargs prototypes no-inline ......................................................................
[WIP] console: Refactor printk() varargs prototypes no-inline
Change-Id: I357af15eea25206a43c93c9578e9b0e271331953 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/console/printk.c M src/include/console/console.h 2 files changed, 13 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/31618/1
diff --git a/src/console/printk.c b/src/console/printk.c index c53f030..270aa1b 100644 --- a/src/console/printk.c +++ b/src/console/printk.c @@ -74,3 +74,15 @@
return i; } + +int do_printk(int msg_level, const char *fmt, ...) +{ + va_list args; + int i; + + va_start(args, fmt); + i = do_printk_va_list(msg_level, fmt, args); + va_end(args); + + return i; +} diff --git a/src/include/console/console.h b/src/include/console/console.h index bdddc98..42698e7 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -83,18 +83,7 @@
int do_printk_va_list(int msg_level, const char *fmt, va_list args);
-static inline __attribute__((format(printf, 2, 3))) -int do_printk(int msg_level, const char *fmt, ...) -{ - va_list args; - int i; - - va_start(args, fmt); - i = do_printk_va_list(msg_level, fmt, args); - va_end(args); - - return i; -} +int __attribute__((format(printf, 2, 3))) do_printk(int msg_level, const char *fmt, ...);
#endif /* !__ROMCC__ */