Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31280 )
Change subject: mb/google/hatch: Enable Audio support
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31280/3/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31280/3/src/mainboard/google/hatch/variants/...
PS3, Line 150: /*AUDIO IRQ*/
nit: add space
https://review.coreboot.org/#/c/31280/3/src/mainboard/google/hatch/variants/...
PS3, Line 151: INVERT
please refer the changes here
https://review.coreboot.org/c/coreboot/+/31328/5/src/mainboard/google/hatch/...
You will have to do similar for an active low interrupt. Also add a todo.
https://review.coreboot.org/#/c/31280/3/src/mainboard/google/hatch/variants/...
PS3, Line 152: /*SPEAKER SD MODE ENABLE*/
nit: add space
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93f3917c19cc3f0f8fd7b5e1b4d9b24a59f45f84
Gerrit-Change-Number: 31280
Gerrit-PatchSet: 3
Gerrit-Owner: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HARSHAPRIYA N
harshapriya.n@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 13 Feb 2019 06:40:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
