Attention is currently required from: Subrata Banik, Christian Walter, Meera Ravindranath, Angel Pons, Lean Sheng Tan.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61528 )
Change subject: mb/intel/adlrvp: Fix vbt loading error
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Isn't this function being added to ensure we have single binary with different vbt configuration. […]
Yes Subrata..this function was added to ensure that we use different VBT binaries based on SKU ID.
I think current issue is all binary must be stitched into coreboot to get this function working else it might throw and error. so when someone wants to just stitch only vbt.bin, they may need this patch to make it work
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61528
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f6f9554b75f4d62198aac9938e65c71c3e7cee9
Gerrit-Change-Number: 61528
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 02 Feb 2022 07:22:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment