John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45608 )
Change subject: soc/intel/xeon_sp: Improve performance efficiencies
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45608/2/src/soc/intel/xeon_sp/cpx/a...
File src/soc/intel/xeon_sp/cpx/acpi.c:
https://review.coreboot.org/c/coreboot/+/45608/2/src/soc/intel/xeon_sp/cpx/a...
PS2, Line 706: iio_resource
then this can be a pointer, and you can just pass `iio_resource` on line 710
It seems not necessary since it would need to allocate and free resource for iio_resource.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45608
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ae9ae38fe2c13c5433aa5e1dcbb30ebd30622ab
Gerrit-Change-Number: 45608
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Sep 2020 23:48:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment