Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44105 )
Change subject: lib/gcov: Remove assert(0)
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44105/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44105/1//COMMIT_MSG@10
PS1, Line 10: custom assert macro
Should we stop hacking/using assert() and provide a standard […]
Sounds reasonable. warn_on() for what we currently have?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44105
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71a38631955a6a45abe90f2b9ce3a924cc5d6837
Gerrit-Change-Number: 44105
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Aug 2020 09:22:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment