Attention is currently required from: Martin Roth, Angel Pons.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51019 )
Change subject: util/spd_tools: Run go fmt on all .go files
......................................................................
Patch Set 1:
(1 comment)
File util/spd_tools/ddr4/gen_spd.go:
https://review.coreboot.org/c/coreboot/+/51019/comment/56435409_4b6ee82e
PS1, Line 978: (i+1)%16
Personally, I'd prefer spaces here, for consistency with other operators
https://stackoverflow.com/questions/59023245/go-fmt-producing-inconsistently... has some background.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51019
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70ced115bad42d123474b18bbff2e4c0a16f3d88
Gerrit-Change-Number: 51019
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 23 Feb 2021 12:54:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment