Attention is currently required from: Sean Rhodes, Michał Żygowski, Patrick Rudolph, Matt DeVillier.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62562 )
Change subject: option: Allow to use the EFI variable driver as option backend
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62562/comment/41a41786_431de80a
PS3, Line 9: region
nit: move to next line to honor the 72 character limit
File src/drivers/efi/option.c:
https://review.coreboot.org/c/coreboot/+/62562/comment/281520ae_e127de3f
PS3, Line 42: return efi_fv_set_option(&rdev, &EficorebootNvDataGuid, name, &var, sizeof(var));
I'm somewhat concerned about returning EFI-specific error codes, even though the return value of `set_uint_option()` is currently never checked.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62562
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I520eca96bcd573f825ed35a29bf8f750e313a02d
Gerrit-Change-Number: 62562
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 07 Apr 2022 12:24:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment