Attention is currently required from: Chen Wisley, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik, Wisley Chen.
Eric Lai has posted comments on this change by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/83291?usp=email )
Change subject: mb/google/nissa/var/domika: Create a domika variant
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83291/comment/cf3e95fc_3e9b440c?usp... :
PS2, Line 12:
remove extra space
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/83291/comment/2a757e46_995ce1a4?usp... :
PS2, Line 819: yavilla
It reuse the yavilla code, so set director to yavilla.
ok.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83291?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I42c56770f8b8d6018592253d2bb16b8166eb5719
Gerrit-Change-Number: 83291
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Mon, 01 Jul 2024 08:23:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Wisley Chen
wisley.chen@quanta.corp-partner.google.com