Attention is currently required from: Tim Wawrzynczak, EricR Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/0a065838_886ee2b4
PS9, Line 18: default y
What do you want to do with this? All chrome project set default y
Just remove the default. abuild has an option to build with CHROMEOS enabled, and Jenkins uses it to build-test both the default (assumed to be !CHROMEOS) and CHROMEOS cases. This default makes Jenkins build-test with CHROMEOS twice.
Related changes: CB:49059 CB:49101 CB:49102 CB:49103
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48111
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5311879a127a2c8da1bbb086449019d932d57b72
Gerrit-Change-Number: 48111
Gerrit-PatchSet: 9
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 29 Jan 2021 11:40:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment