Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35634 )
Change subject: vboot: create board-specific test-only GBB HWID if not set
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid...
File src/security/vboot/gen_hwid.sh:
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid...
PS1, Line 38: crc="$(python -c "import zlib, sys; sys.stdout.write(\
b) Add an option in gbb_utility to say append CRC32 to HWID.
And, it will require adding some knowledge to vboot/futility what append to HWID means.
Definitely not this. It'll confuse people who use HWID v3.
It will end up being used only by coreboot.
Let's keep it only in coreboot :) Since this is actually caused by our moving build logic from chromeos-bootimage into coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35634
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0cda17a374641589291ec8dfb1d66c553f7cbf35
Gerrit-Change-Number: 35634
Gerrit-PatchSet: 3
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Sat, 28 Sep 2019 05:26:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment