Attention is currently required from: Julius Werner. zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59044 )
Change subject: mb/google/trogdor: Adjust mipi panel backlight gpio ......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/59044/comment/49d99cef_a381604a PS5, Line 16: #define GPIO_TP_EN GPIO(85)
This should be under the #if below, and set to dead_code_t(gpio_t) for eDP boards.
Thanks for your warning.
File src/mainboard/google/trogdor/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59044/comment/fa119829_1e77a17f PS5, Line 18: gpio_output(GPIO_TP_EN, 0);
Is this necessary? This pin should already be a pull-down on reset.
Done. It does seems like a bit redundant.
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/59044/comment/ad09fc91_7eec3cf3 PS5, Line 145: if (CONFIG(BOARD_GOOGLE_MRBLAND) || CONFIG(BOARD_GOOGLE_WORMDINGLER))
Why not TROGDOR_HAS_MIPI_PANEL? I hope this part is the same across all MIPI variants?
Thanks, Julius. My original intention was to worry about that other variant's schematic would have difference about the mipi panel lighting. I'm not sure that's the case. Please give some advice.