Attention is currently required from: Arthur Heymans.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84056?usp=email )
Change subject: drivers/intel/gma: Fix mismatching types for fb_add_framebuffer_info ......................................................................
Patch Set 6: Code-Review+1
Copied votes on follow-up patch sets have been updated: * Code-Review+1 has been copied to patch set 7 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN").
(1 comment)
Patchset:
PS6: I don't mind doing this, but want to provide some context / alternatives: Pretending it's `size_t` apparently was a simplification to avoid adding a lot of details just for the null-check. So if it's just a null-check we want, and we want to do it without tricks, we could also move it to C.
Could be something like ``` int fb_add_framebuffer_info_simple( uintptr_t fb_addr, uint32_t x_res, uint32_t y_res, uint32_t bytes_per_line, uint8_t bits_per_pixel) { return fb_add_framebuffer_info(fb_addr, x_res, y_res, bytes_per_line, bits_per_pixel) != NULL; } ``` And call that from Ada.
OTOH, if we keep the current API and add all the definitions in Ada (never know, might be useful in the future), then we have to keep C and Ada in sync and should at least keep some comments around that remind us.