[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Leverage CBFS_CACHE when using SPI DMA

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74334 )

Change subject: soc/amd/common/block/lpc/spi_dma: Leverage CBFS_CACHE when using SPI DMA
......................................................................

Patch Set 5:

(3 comments)

File src/soc/amd/common/block/lpc/spi_dma.c:

https://review.coreboot.org/c/coreboot/+/74334/comment/8d2224c1_0a9dd17d 
PS4, Line 218: 	if (!CONFIG_CBFS_CACHE_SIZE)
> Correct. […]

Usage model has been:
1) Map the space (rdev_map_full)
2) Consume from the mapped space
3) Unmap it.

So the cbfs_cache gets released after the use. Also for FSP-M, once it is loaded into cbfs_cache, it is possible to explore other faster decompression options like LZ4. Without that, we will have to live with LZMA.

Your comment about ref1 is fair. I have addressed it.

https://review.coreboot.org/c/coreboot/+/74334/comment/d4bbd8fe_a467867d 
PS4, Line 223: 		printk(BIOS_INFO, "%s: Could not allocate from memory pool\n", __func__);
> Please log `size` here also, so we know how much we're trying to allocate and whether it even has a  […]

Done

https://review.coreboot.org/c/coreboot/+/74334/comment/a1eb3547_c2b9d79f 
PS4, Line 230: 		mem_pool_free(&cbfs_cache, mapping);
             : 		/* Fall-back to memory map */
             : 		return &mdev->base[offset];
> ref1

Done