Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41035 )
Change subject: soc/intel/common/gpio_defs: Fix coding style
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41035/13/src/soc/intel/common/block...
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/41035/13/src/soc/intel/common/block...
PS13, Line 155:
hmm, not sure if using tabs here really makes it cleaner... I'd have used a single space here (and for all the others too) but that may be personal preference
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4b4c28153398b6275728b28bda90e527d97e823
Gerrit-Change-Number: 41035
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 11 Jul 2020 11:07:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment