[coreboot-gerrit] [M] Change in coreboot[main]: soc/intel/xeon_sp: Add PCIe root port driver

[Patrick Rudolph (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Jincheng Li, Johnny Lin, Jonathan Zhang, Lance Zhao, Lean Sheng Tan, Shuo Liu, Tim Chu, Tim Wawrzynczak.

Patrick Rudolph has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/81567?usp=email )

Change subject: soc/intel/xeon_sp: Add PCIe root port driver
......................................................................

Patch Set 11: Code-Review+2

(4 comments)

File src/soc/intel/xeon_sp/acpi.c:

https://review.coreboot.org/c/coreboot/+/81567/comment/48ab382d_c15a57a0?usp... :
PS11, Line 121: is_pci_bridge
This should only be necessary for device that do not have it's own `acpi_name` function ptr in `struct device_operations`. See comment on pcie_root_port.c

File src/soc/intel/xeon_sp/pcie_root_port.c:

https://review.coreboot.org/c/coreboot/+/81567/comment/c3d8a0d0_763f7f76?usp... :
PS11, Line 10: pcie_device_set_acpi_name
Rename to `pcie_device_get_acpi_name` and handle downstream devices here. `acpi_device_name()` will call this function for each downstream device to get their name.

https://review.coreboot.org/c/coreboot/+/81567/comment/df37f784_0edd6291?usp... :
PS11, Line 48: 	}
Missing call to pci_dev_init().

https://review.coreboot.org/c/coreboot/+/81567/comment/3a788528_a9ec43e7?usp... :
PS11, Line 71: acpi_fill_ssdt
add `.acpi_name  = pcie_device_get_acpi_name,`