Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42662 )
Change subject: sb/intel/i82801gx: Use common early SPI code
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42662/1/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801gx/bootblock.c:
https://review.coreboot.org/c/coreboot/+/42662/1/src/southbridge/intel/i8280...
PS1, Line 10: enable_spi_prefetching_and_caching
This is currently done unconditionally. I am not changing the behavior of the code with this commit. […]
Oh right, I see why you asked now: the code doesn't get built and fails for some boards...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44de4698d062508dd24f37b37014e09d95726c71
Gerrit-Change-Number: 42662
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 21 Jun 2020 16:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment