Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34149 )
Change subject: intel/e7505,i82801dx: Fix SMM_ASEG lock
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34149/4/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801dx/smi.c:
https://review.coreboot.org/c/coreboot/+/34149/4/src/southbridge/intel/i8280...
PS4, Line 322:
Original code wrote completely wrong 0x90 and SMIs still worked. […]
Missed that 0x90 (also after reading you comment ^^ thought, you are
talking about register values).
All documentation I found about it pointed to the VGA framebuffer if
G_SMRAME is disabled. Maybe it works because VGA resources are not
enabled yet?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34149
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21d991c8c2f5c2dde1f148fd80963e39d9836d3c
Gerrit-Change-Number: 34149
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 15 Jul 2019 08:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment